feat(porkbun): switch to global variables for keys

- Introduce 2 global variables with API keys
- Remove redundant role that only installs one config file used by
  another role
- Use the said global variables within DDNS and Certbot roles
- Create the config file in the role that uses it (Certbot)

Signed-off-by: Matej Focko <me@mfocko.xyz>

defaults/main.yml

@@ -27,6 +27,11 @@ hashicorp_vault_address: None
 # Address of the Vaultwarden instance
 vaultwarden_address: None
 
+# Porkbun ‹apikey› and ‹secretapikey› that are used by Certbot (SSL/TLS renewal)
+# and DDNS (updating DNS records)
+porkbun_apikey: None
+porkbun_secretapikey: None
+
 # Public ID tied to the Yubikey OTP
 yubikey_token_id: None
 

roles/certbot/tasks/main.yml

@@ -11,6 +11,12 @@
     owner: root
     group: root
 
+- name: Create the file with Porkbun secrets
+  ansible.builtin.template:
+    src: templates/porkbun.ini
+    dest: /etc/porkbun.ini
+    mode: 0600
+
 - name: Install the Porkbun Certbot container definition (quadlet)
   ansible.builtin.template:
     src: templates/certbot.container

roles/certbot/templates/porkbun.ini

@@ -0,0 +1,2 @@
+dns_porkbun_key={{ porkbun_apikey }}
+dns_porkbun_secret={{ porkbun_secretapikey }}

roles/ddns/defaults/main.yml

@@ -4,9 +4,3 @@ ddns_domain: None
 
 # List of all subdomains on the said domain for which the IP should be set
 ddns_subdomains: []
-
-# ‹apikey› provided by Porkbun
-ddns_porkbun_apikey: None
-
-# ‹secretapikey› provided by Porkbun
-ddns_porkbun_secretapikey: None

roles/ddns/templates/ddns.ini

@@ -1,4 +1,4 @@
 DOMAIN={{ ddns_domain }}
 SUBDOMAINS={{ ','.join(ddns_subdomains) }}
-APIKEY={{ ddns_porkbun_apikey }}
-SECRETAPIKEY={{ ddns_porkbun_secretapikey }}
+APIKEY={{ porkbun_apikey }}
+SECRETAPIKEY={{ porkbun_secretapikey }}

roles/porkbun/defaults/main.yml

@@ -1,6 +0,0 @@
----
-# ‹apikey› provided by Porkbun
-porkbun_key: None
-
-# ‹secretapikey› provided by Porkbun
-porkbun_secret: None

roles/porkbun/tasks/main.yml

@@ -1,6 +0,0 @@
----
-- name: Create the file with Porkbun secrets
-  ansible.builtin.template:
-    src: templates/porkbun.ini
-    dest: /etc/porkbun.ini
-    mode: 0600

roles/porkbun/templates/porkbun.ini

@@ -1,2 +0,0 @@
-dns_porkbun_key={{ porkbun_key }}
-dns_porkbun_secret={{ porkbun_secret }}