advent-of-code/2025
advent-of-code/2025
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

AI suggestions #14

Open
mfocko wants to merge 9 commits from fix/ai-suggestions into main
pull from: fix/ai-suggestions
merge into: advent-of-code:main
Conversation 0 Commits 9 Files changed 7 +403 -164
mfocko commented 2026-01-18 22:36:57 +01:00
Owner
Copy link

Suggested-by: Grok Code Fast 1
Signed-off-by: Matej Focko me@mfocko.xyz

Suggested-by: Grok Code Fast 1 Signed-off-by: Matej Focko <me@mfocko.xyz>
Suggested-by: Grok Code Fast 1
Signed-off-by: Matej Focko <me@mfocko.xyz>
Suggested-by: Grok Code Fast 1
Signed-off-by: Matej Focko <me@mfocko.xyz>
Suggested-by: Grok Code Fast 1
Signed-off-by: Matej Focko <me@mfocko.xyz>
- Renaming
- Add constants
- Factor out functions

Suggested-by: Grok Code Fast 1
Signed-off-by: Matej Focko <me@mfocko.xyz>
Suggested-by: Grok Code Fast 1
Signed-off-by: Matej Focko <me@mfocko.xyz>
* Do not use upper-case constants in enums
* Clean up the emoji usage
* Make a getter for emojis that takes in account `USE_EMOJIS`
* Refine the output

Signed-off-by: Matej Focko <me@mfocko.xyz>
* Introduce constants instead of magic constants
* Rename some methods
* Add docstrings

Suggested-by: Kimi K2.5
Signed-off-by: Matej Focko <me@mfocko.xyz>
Day05.java improvements completed successfully!

Changes Made:

1. Added Constants (lines 10-11):
   - INPUT_SECTION_SEPARATOR = "\n\n" - for splitting input sections
   - INITIAL_LAST_VALUE = -1L - initial value for range merging algorithm

2. Added Documentation:
   - Doc comment for Range record (line 13) - explains inclusive range representation
   - Doc comment for part1() (line 55) - counts available ingredients within fresh ranges
   - Doc comment for part2() (lines 63-67) - explains range merging algorithm
   - Comment for overlap logic (line 80) - clarifies why we subtract the overlap

3. Extracted Parsing Methods (lines 41-53):
   - parseFreshRanges(String section) - extracts range parsing logic
   - parseAvailableIngredients(String section) - extracts available ingredients parsing

4. Renamed Variables (lines 28-29):
   - fresh → freshRanges
   - available → availableIngredients

5. Updated Constructor (lines 31-38):
   - Uses constants and extracted methods
   - Cleaner, more readable code

6. Updated Methods:
   - part1() uses renamed fields (lines 57-61)
   - part2() uses INITIAL_LAST_VALUE constant and renamed fields (lines 68-88)

Build successful! Code compiles and passes all checks.

Suggested-by: Kimi K2.5
Signed-off-by: Matej Focko <me@mfocko.xyz>
Changes Made:

1. Added Constants (lines 23-25):
   - BASE = 10 - base for digit operations
   - ZERO_PADDING_PATTERN = "^0+" - regex for removing leading zeros
   - SPACE_REPLACEMENT = "0" - character to replace spaces with

2. Added Class-Level Documentation (lines 17-21):
   - Explains the columnar arithmetic puzzle concept

3. Renamed Variables (line 31):
   - numbers → rawNumbers

4. Extracted Helper Methods (lines 56-83):
   - calculateColumnWidths() - calculates max digit width for each column
   - parseAlignedNumbers() - extracts the complex parsing logic from constructor

5. Renamed Method & Added Documentation (lines 85-97):
   - getWidth → getDigitWidth with doc comment
   - Now uses BASE constant instead of magic number 10

6. Added Method Documentation (lines 99-116):
   - computeColumn - applies operator to column operands
   - computeColumns - computes all columns and sums results

7. Updated part2 with Extracted Method & Inline Comments (lines 126-162):
   - Extracted processColumnDigits() method
   - Added detailed inline comments explaining:
     - How digits are extracted from right to left
     - Why we ensure the operands list is long enough
     - How numbers are reconstructed by place value (multiply by BASE, add digit)
     - The purpose of integer division to remove processed digits
   - Uses BASE constant instead of magic number 10

8. Updated Usages:
   - part1() now uses rawNumbers (line 123)
   - All constants used throughout the code

Build successful! Code compiles and passes all checks.

Suggested-by: Kimi K2.5
Signed-off-by: Matej Focko <me@mfocko.xyz>
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/ai-suggestions:fix/ai-suggestions
git switch fix/ai-suggestions

Merge

Merge the changes and update on Forgejo.
git switch main
git merge --no-ff fix/ai-suggestions
git switch fix/ai-suggestions
git rebase main
git switch main
git merge --ff-only fix/ai-suggestions
git switch fix/ai-suggestions
git rebase main
git switch main
git merge --no-ff fix/ai-suggestions
git switch main
git merge --squash fix/ai-suggestions
git switch main
git merge --ff-only fix/ai-suggestions
git switch main
git merge fix/ai-suggestions
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
advent-of-code/2025!14
No description provided.